feat: Add AWS Bedrock Extended Thinking support for Claude models (#4201) #4480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor Bedrock provider for clarity and type safety. - Extract constants and helper methods. - Update documentation. - Rename and update reasoning tests to Vitest. - Ensure all tests pass.
- Add StreamChunk interface with proper type definitions - Update all generator methods to use Generator<StreamChunk, void, unknown> - Addresses review feedback for better type safety
- Replace custom StreamChunk interface with ApiStreamChunk import - Update all generator method signatures to use ApiStreamChunk - Fixes type compatibility issues with yield* delegation - Resolves CI test failures related to type mismatches
…bility - Replace multiple handler methods with unified processStreamEvent() - Simplify main stream processing loop from ~30 lines to 1 line - Maintain all existing functionality and test coverage - Address PR reviewer feedback for improved code organization Addresses: Stream processing consolidation suggestion from PR review
dosubot
bot
added
size:L
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| /** | ||
| * Determines if extended thinking should be enabled based on model support and user settings | ||
| */ | ||
| private shouldEnableExtendedThinking(modelInfo: ModelInfo, params: any): boolean { |
Contributor
There was a problem hiding this comment.
Consider replacing the use of any for the parameter params in shouldEnableExtendedThinking() with a more specific type. This will improve type safety and clarity.
Suggested change
| private shouldEnableExtendedThinking(modelInfo: ModelInfo, params: any): boolean { | |
| private shouldEnableExtendedThinking(modelInfo: ModelInfo, params: { reasoning?: boolean; reasoningBudget?: number }): boolean { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4201
Adds AWS Bedrock Extended Thinking support for Claude Sonnet 4, Opus 4, and 3.7 Sonnet models. Users can now enable reasoning mode when using AWS Bedrock, matching the functionality available with the direct Anthropic provider.
Changes Made
API Implementation:
additionalModelRequestFields.thinkingconfiguration to Bedrock API payloadscontentBlockStart,contentBlockDelta)anthropic_versionparameter for thinking requestsshouldUseReasoningBudget()logicUI Updates:
Testing:
Technical Details
:thinkingmodel variantstopPparameter when thinking is enabled (AWS requirement)Testing
Files Changed
packages/types/src/providers/bedrock.ts- Type definitions for reasoningsrc/api/providers/bedrock.ts- Core thinking functionalitysrc/api/providers/__tests__/bedrock-reasoning.test.ts- Test coveragewebview-ui/src/components/settings/- UI improvements for reasoning controlsImportant
Adds AWS Bedrock Extended Thinking support for Claude models, enabling reasoning mode with API, UI, and testing updates.
additionalModelRequestFields.thinkingto Bedrock API payloads inbedrock.ts.contentBlockStart,contentBlockDelta) inbedrock.ts.anthropic_versionparameter for thinking requests inbedrock.ts.shouldUseReasoningBudget()logic inbedrock.ts.bedrock-reasoning.spec.ts.bedrock-reasoning.spec.ts.This description was created by
for 13e272c. You can customize this summary. It will automatically update as commits are pushed.